Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4467: Add support for DML statements in stress test ......................................................................
Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/5093/9//COMMIT_MSG Commit Message: Line 14: > It would be helpful to have 1-2 examples of a full concurrent_select.py cal Done http://gerrit.cloudera.org:8080/#/c/5093/9/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: PS9, Line 1682: help="If True, databases will be reset to their original state after the binary" : " search.") > On L1971 you say it "may be a good idea" to use this option. I think it mig Done. Improved the help text. PS9, Line 1871: def populate_all_queries(queries): > It's odd for a function of this size to live in a scope of its size. Can yo We would also have to pass in other variables into this function, such as impala, args, runtime_info_path. This seems kind of excessive to me. -- To view, visit http://gerrit.cloudera.org:8080/5093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2aafdc6851cc0e1677a3c668d3350e47c4bfe40 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
