Michael Brown has posted comments on this change. Change subject: IMPALA-4467: Add support for DML statements in stress test ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/5093/9/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: PS9, Line 1871: def populate_all_queries(queries): > The code already has methods that do that, like load_random_queries_and_pop Sorry, to be clear, although I feel main() is too long, I'm not asking you to take steps to drastically shorten it. I simply want the nested function made separate to somewhat reduce a main() that is already too long. -- To view, visit http://gerrit.cloudera.org:8080/5093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2aafdc6851cc0e1677a3c668d3350e47c4bfe40 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
