Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow ......................................................................
Patch Set 12: (2 comments) Thank you. I have modified the code according to your opinion. http://gerrit.cloudera.org:8080/#/c/4971/11/be/src/common/logging.cc File be/src/common/logging.cc: PS11, Line 181: max_log_files <= > nit: rewrite as <= 0 to be consistent with other places Done http://gerrit.cloudera.org:8080/#/c/4971/11/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 272: static const string AUDIT_EVENT_LOG_FILE_PREFIX; > Let's remove this function and simplify things by making AUDIT_EVENT_LOG_FI Done -- To view, visit http://gerrit.cloudera.org:8080/4971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368 Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu <[email protected]> Gerrit-Reviewer: Donghui Xu <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
