Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow ......................................................................
Patch Set 11: > (3 comments) > > I have modified the code according to your opinion. The minimum > number of audit event log file should be 1 and 0 represents no > limit. Have you tested that specifying 1 actually works as expected? The other method CheckAndRotateLogFiles() still has the <=1 check, and I'm not sure why it was implemented that way. -- To view, visit http://gerrit.cloudera.org:8080/4971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368 Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu <[email protected]> Gerrit-Reviewer: Donghui Xu <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: No
