Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5686
Change subject: IMPALA-4747: macros should only evaluate their arguments once ...................................................................... IMPALA-4747: macros should only evaluate their arguments once The way the macros were previously written, they expanded so that the 'status' expression was duplicated. This means if the expression has side-effects, they happen twice. The fix is to introduce a temporary variable. Change-Id: I1229849150d3f747e6780cc072ba063152ade1a9 --- M be/src/exec/hash-table-test.cc M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/tmp-file-mgr-test.cc M be/src/testutil/gtest-util.h 4 files changed, 20 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/5686/1 -- To view, visit http://gerrit.cloudera.org:8080/5686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1229849150d3f747e6780cc072ba063152ade1a9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]>
