Jim Apple has posted comments on this change. Change subject: IMPALA-4747: macros should only evaluate their arguments once ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5686/2/be/src/testutil/gtest-util.h File be/src/testutil/gtest-util.h: Line 30: const Status& __status = (status); \ "Each identifier that contains a double underscore __ or begins with an underscore followed by an uppercase letter is reserved to the implementation for any use." -- To view, visit http://gerrit.cloudera.org:8080/5686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1229849150d3f747e6780cc072ba063152ade1a9 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
