Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4878/6/be/src/runtime/disk-io-mgr-test.cc File be/src/runtime/disk-io-mgr-test.cc: Line 791: ASSERT_OK(io_mgr.Init(&mem_tracker)); > why was this only caught by clang-tidy and not by the new warn unused resul Good question. I'll have to figure that out - I won't resolve the JIRA until we've figured that out (and added the annotation in a few more places, probably). -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c26e7532b5f2c7fe167accc73179e8b72b192bc Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
