Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored ......................................................................
Patch Set 7: Turns out there's a gcc bug that prevents this from working sometimes (including for DiskIoMgr::Init()). I updated the commit message to include this info. Shall we still go ahead even with this caveat? I think this is still worthwhile since clang will detect the problems/ -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c26e7532b5f2c7fe167accc73179e8b72b192bc Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
