Bharath Vissapragada has posted comments on this change. Change subject: Improve logging of table loading. ......................................................................
Patch Set 1: (11 comments) http://gerrit.cloudera.org:8080/#/c/5709/1//COMMIT_MSG Commit Message: Line 7: Improve logging of table loading. JIRA id? I think it helps in backporting to other branches. http://gerrit.cloudera.org:8080/#/c/5709/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: Line 528: LOG.trace("Loading native functions for database: " + db.getName()); Should we enable logging related to fns (here and below) ? I think it helps figuring out startup issues and IIUC this is not a frequent operation (I might be wrong here). Line 898: LOG.debug(String.format("Refreshing metadata: %s", tbl.getFullName())); Given we support both table & partition granularity, Is it better to explicitly mention table/partition in the statement? Refreshing table metadata...? (Same below) Line 1036: tableName.getDb_name(), tableName.getTable_name())); this and invalidateDb()? Can potentially help the frequency with which invalidates are run. Line 1262: public Table reloadPartition(Table tbl, List<TPartitionKeyValue> partitionSpec) Should we add this too? http://gerrit.cloudera.org:8080/#/c/5709/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: Line 681: LOG.debug("Creating empty partition objects: " + getFullName()); Log statment would probably be confusing for non-partitioned tables? Should we move it to after L713 or rephrase here? PS1, Line 1057: db_.getName() + "." + name_ getFullName()? Line 1081: LOG.debug("Incrementally loaded metadata for: " + tableName); I have a feeling these could be noisy and can do a lot of logging. http://gerrit.cloudera.org:8080/#/c/5709/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: Line 570: LOG.debug("Loading table metadata: " + tbl.getFullName()); This will be logged twice for non-hdfs tables, once here and once inside Table.load()? http://gerrit.cloudera.org:8080/#/c/5709/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: PS1, Line 832: info debug like others for consistency? Line 915: LOG.trace(String.format("Missing tables were not received in %dms. Load " + Isn't this a warn/error? -- To view, visit http://gerrit.cloudera.org:8080/5709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8de96d0cb6d09b2272b1925d42cb059367fe7196 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-HasComments: Yes
