Alex Behm has posted comments on this change. Change subject: IMPALA-4768: Improve logging of table loading. ......................................................................
Patch Set 3: (2 comments) I agree our logging story needs an overhaul, but that's a project and not a fix. http://gerrit.cloudera.org:8080/#/c/5709/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: PS3, Line 241: BlockMetadataLoadStats > Thanks for explaining. Based on the name, I would also expect something lik We can easily get the file count info from HDFS if we suspect such a perf issue. I removed this to minimize the changes. PS3, Line 244: // Number of files that were found to belong to the table being loaded. : public long tableFileCount = 0; > Hm, maybe a better name for these fields? e.g. examinedFilesCount and table I removed the BlockMetadataLoadStats to simplify this patch. -- To view, visit http://gerrit.cloudera.org:8080/5709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8de96d0cb6d09b2272b1925d42cb059367fe7196 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
