Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4733: Avoid using several loading threads on one table. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5707/1/fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java File fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java: Line 280: tableLoadingSet_.remove(tblName); > There's still a window for a race here if multiple threads pull the same en tableLoadingSet_ seems to be a synchronized (thread-safe) one? private final Set<TTableName> tableLoadingSet_ = Collections.synchronizedSet(new HashSet<TTableName>()); -- To view, visit http://gerrit.cloudera.org:8080/5707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba5f1808e0b9cbbcf46245834d8ad38d01231cb Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
