Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step ......................................................................
Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/5739/3//COMMIT_MSG Commit Message: PS3, Line 7: a > Captialize? Looking back through the commit history I see a mix. I don't think it really matters PS3, Line 11: acquires > acquired Done http://gerrit.cloudera.org:8080/#/c/5739/3/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 468: RETURN_IF_ERROR(query_state_->PrepareForExecution()); > actually, this won't work in the future: to do meaningful preparation, you' For reservations specifically, I anticipate that the planner would compute the minimum reservation and this could be included in the TQueryExecRequest or one of the query-wide data structures. There are probably some follow-on tasks that would want to see more of the query plan. http://gerrit.cloudera.org:8080/#/c/5739/3/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: Line 53: InitMemTrackers(pool); > move to prepare I originally did it that way, then realised that it creates complications with the lifecycle of query_mem_tracker. E.g. ImpalaHttpHandler::QueryMemoryHandler() would have to check whether it's null. I don't feel that strongly about it, but this seemed simplest overall. Line 68: if (prepared_) return Status::OK(); > in that case prepared_status_ should also be ok; add a dcheck Done Line 72: // Starting a new fragment instance creates a thread and consumes a non-trivial > rephrase; this isn't called per instance Done http://gerrit.cloudera.org:8080/#/c/5739/3/be/src/runtime/query-state.h File be/src/runtime/query-state.h: Line 102: Status PrepareForExecution(); > Prepare() (what else would it prepare for?) Done -- To view, visit http://gerrit.cloudera.org:8080/5739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia21a3c0f0b0a7175116883ef9871b93c8ce8bb81 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
