Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5739/6/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: Line 83: prepare_status_ = process_mem_tracker->MemLimitExceeded(NULL, msg, 0); > And how is this integrating with admission control? Ideally if the query is this isn't integrated with admission control yet. we will need to revise it once we actually integrate. -- To view, visit http://gerrit.cloudera.org:8080/5739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia21a3c0f0b0a7175116883ef9871b93c8ce8bb81 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
