Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs ......................................................................
Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5161/11/be/src/exprs/agg-fn-evaluator.cc File be/src/exprs/agg-fn-evaluator.cc: PS11, Line 546: AnyValUtil::ColumnTypeToTypeDesc(output_slot_desc_->type()) > Is that actually right / useful for Update() / Merge() functions ? That sho It's right in that it does what is documented in udf.h and is consistent with the interpreted path here (see the call to FunctionContextImpl::CreateContext()). Would I have chosen this behaviour? I'm unsure. It kind of makes sense but can be confusing. It's not directly useful to expose GetReturnType() to the Update()/Merge() functions, since they won't be operating on that type. -- To view, visit http://gerrit.cloudera.org:8080/5161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1708eaa96eb76fb9bec5eeabf209f81c88eec2f Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
