Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs ......................................................................
Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5161/13/be/src/exprs/scalar-fn-call.h File be/src/exprs/scalar-fn-call.h: Line 53: /// Loads a native or IR UDF or UDA function 'fn' with symbol 'symbol' from the > the term 'scalar function' means 'not an aggregate function'. i don't under I'm fine with moving it to a different class, I mainly wanted to leave as-is initially so that reviewer could review the diff of the function implementation. -- To view, visit http://gerrit.cloudera.org:8080/5161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1708eaa96eb76fb9bec5eeabf209f81c88eec2f Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
