Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-3748: add query-wide resource acquisition step ......................................................................
IMPALA-3748: add query-wide resource acquisition step This adds a Prepare() method to QueryState that allows query execution to fail up-front if resources cannot be acquired. We don't make full use of this yet, but it provides a suitable place to acquire a memory reservation for the query or fail cleanly. The process memory limit check is moved here so that all startup memory checks will be eventually consolidated in one place. Also switch a boost::mutex to a SpinLock for consistency and to improve performance (see lock-benchmark.cc). Change-Id: Ia21a3c0f0b0a7175116883ef9871b93c8ce8bb81 Reviewed-on: http://gerrit.cloudera.org:8080/5739 Tested-by: Impala Public Jenkins Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> --- M be/src/runtime/query-exec-mgr.cc M be/src/runtime/query-exec-mgr.h M be/src/runtime/query-state.cc M be/src/runtime/query-state.h M be/src/runtime/test-env.cc 5 files changed, 58 insertions(+), 19 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia21a3c0f0b0a7175116883ef9871b93c8ce8bb81 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
