Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/2//COMMIT_MSG Commit Message: Line 11: since function names act as bare identifiers. > Can you also run a basic perf test to compare the speed of regex_replace() I don't think std::replace would work here - the input isn't exactly easily modeled as an iterator since we are replacing multiple characters and one can imagine nasty side effects if this isn't explicitly coded, with say: replace('strstrstr', 'str', 'strstr') -- To view, visit http://gerrit.cloudera.org:8080/5776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
