Dan Hecht has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 1963: TestIsNull("replace('zomg', 'foo', NULL)", TYPE_STRING); as michael mentioned previously, we should also test this with non-constant args using end-to-end test. while you aren't exploiting IsArgConstant(), it's common to do so (grep for that in the string-functions-ir.cc file for examples). see exprs.test and test_exprs.py for examples of end-to-end functional cases. -- To view, visit http://gerrit.cloudera.org:8080/5776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
