Jim Apple has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool ......................................................................
Patch Set 16: (1 comment) clang-tidy found this, but the Jenkins jobs that runs clang-tidy has confusing output (my mistake). http://gerrit.cloudera.org:8080/#/c/5584/16/be/src/testutil/death-test-util.h File be/src/testutil/death-test-util.h: Line 40: #define IMPALA_ASSERT_DEBUG_DEATH((void)fn, msg) invalid token in macro parameter list -- To view, visit http://gerrit.cloudera.org:8080/5584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c6119a4557da853fefa02e17c49d8be0e9fbe01 Gerrit-PatchSet: 16 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
