Jim Apple has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool ......................................................................
Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/5584/17/be/src/runtime/bufferpool/buffer-pool.h File be/src/runtime/bufferpool/buffer-pool.h: Line 306: alignas(CACHE_LINE_SIZE) SpinLock clean_pages_lock_; type 'impala::BufferPool' requires 64 bytes of alignment and the default allocator only guarantees 16 bytes [clang-diagnostic-over-aligned] You can inherit from CacheLineAligned. Since you have defined CACHE_LINE_SIZE in this patch, you could change the constant 64 in aligned-new.h to be CACHE_LINE_SIZE. -- To view, visit http://gerrit.cloudera.org:8080/5584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c6119a4557da853fefa02e17c49d8be0e9fbe01 Gerrit-PatchSet: 17 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
