Jim Apple has posted comments on this change. Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. ......................................................................
Patch Set 3: > > (1 comment) > > > > I did my own survey for this renaming and feel you have > identified > > the correct files to change. I looked at the diff and saw that > most > > of the changes were renames, with a few indent changes that seem > > logical. I thought about asking you to clean up the flake8 issues > > around the changes, but that would make the diff harder to read. > > > > I think you need to send a note to the dev@ list mentioning this > > name change, and that in-flight patches that add or modify python > > test suites could or will break after this gets cherry-picked. > > > > Also, please keep up with subsequent cherry-picks to the repo > > before you run GVO: you don't want an in-flight patch that adds > > Python tests to "beat" yours, and then you not update it. You'll > > need to watch carefully to rebase. > > > > I can +1 once you report an exhaustive run with no NameErrors > etc. > > I just started an exhaustive run: > http://jenkins.impala.io:8080/view/Utility/job/pre-review-test/8/ > > Right now, Impala Public Jenkins is not generally open to > non-committers. However, the pre-review-test job is open to > everyone, and so it can be read and referenced in code reviews more > easily than running tests on your development machine. Exhaustive job passed. Now I'm just waiting for confirmation from you (David) that nobody is using test_targeted_perf.py. Michael asked for a couple of other things, too. -- To view, visit http://gerrit.cloudera.org:8080/5794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06b7bc6fd99fbb637a47ba376bf9830705c1fce1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: No
