David Knupp has posted comments on this change. Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. ......................................................................
Patch Set 3: Yup. I addressed Michael's request with regard to updating the commit message. I was going to wait until I got a +2 before emailing the dev@ list (which was his other request.) With regard to test_targeted_perf, I sent mail to the internal Impala list, and no one seems to be running it. Indeed, I got two votes for just deleting the file entirely. So I think we're fine with the changes in this patch. For deleting it, I'd probably just submit a new patch. -- To view, visit http://gerrit.cloudera.org:8080/5794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06b7bc6fd99fbb637a47ba376bf9830705c1fce1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: No
