Tim Armstrong has posted comments on this change. Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5788/1//COMMIT_MSG Commit Message: > Since this is a security issue, maybe worth noting when this was introduced Done http://gerrit.cloudera.org:8080/#/c/5788/1/be/src/common/global-flags.cc File be/src/common/global-flags.cc: Line 94: // Stress option for testing failed memory allocation. Debug builds only. > This comment seems weird, since it looks like it applies to the whole #ifnd Done -- To view, visit http://gerrit.cloudera.org:8080/5788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I956bae0685e863f30be23634b29aa076394db184 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
