Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() ......................................................................
Patch Set 9: Michael, yeah, I will fix those. I still need to plug in the additional tests that will be required now that we do constant based stuff. Dan - replace ' ' -> '' was the initial test. This was much faster, 2x so. Regexp compilation starts to be more competitive on longer expressions because it has more advanced state. Still it can't beat a cached StringSearch - 'complicated' actually isn't that complicated, but it (due to the repeated 'c') allows the search to advance faster, better illustrating the difference on longer strings. -- To view, visit http://gerrit.cloudera.org:8080/5776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: No
