Alex Behm has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5776/10//COMMIT_MSG Commit Message: Line 13: Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329 Can you clarify whether replace() is faster than regexp_replace() in simple cases? Otherwise, there's no point in a custom implementation versus just internally calling regexp_replace(). http://gerrit.cloudera.org:8080/#/c/5776/6/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: Line 2619: /* Since "IF", "TRUNCATE" are keywords, need to special case these functions */ update comment -- To view, visit http://gerrit.cloudera.org:8080/5776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
