Michael Ho has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen ......................................................................
Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/5732/5/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 173: RETURN_IF_ERROR(init_codegen->MaterializeModule()); > seems fine, but why is this needed now but not before? oh i guess it's requ Yup. We cannot find uses without materializing the module first. That's why we do it once at init time. PS5, Line 185: functions > functions / global-variables Took the suggestion in the next comment. Line 201: fns_to_always_materialize_.insert(fn_name); > if we put it in fns_to_always_materialize_ (and therefore will be materiali Done PS5, Line 328: Note that : // linking will cause functions defined only in the new module to be materialized. > does linkModule() actually materialize functions? or is this saying that on linkModule() will materialize function. http://gerrit.cloudera.org:8080/#/c/5732/5/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: PS5, Line 146: be > by Done -- To view, visit http://gerrit.cloudera.org:8080/5732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40fdb035a565ae2f9c9fbf4db48a548653ef7608 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
