Tim Armstrong has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen ......................................................................
Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5732/4/be/src/exprs/timestamp-functions.h File be/src/exprs/timestamp-functions.h: Line 44: /// with its defined max year. date(max_date_time).year() will give 9999 but testing I missed updating MAX_YEAR to 9999 in my patch 69859bddfb058d742cece7d7c2e3e3f07f29bb6a - this comment about boost being inconsistent no longer applies. I can also do this in a separate patch but it might be easiest just to fix it now. -- To view, visit http://gerrit.cloudera.org:8080/5732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40fdb035a565ae2f9c9fbf4db48a548653ef7608 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
