Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode ......................................................................
Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/5494/1//COMMIT_MSG Commit Message: Line 7: Clarify synchronization policy for 'done_' in KuduScanNode > Is there a Jira? Just added one and updated the JIRA. PS1, Line 9: calrify > typo Done PS1, Line 9: calrify > sp Done http://gerrit.cloudera.org:8080/#/c/5494/1/be/src/exec/kudu-scan-node.cc File be/src/exec/kudu-scan-node.cc: Line 217: unique_lock<mutex> lock(lock_); > it would be handy for this to return null if done_. I don't think it's stri Done PS1, Line 257: while (!done_) { > Now that I look at this more, I think this is weird that we check_ done but Done PS1, Line 281: done_ > please add a comment that even if this read conflicts with a write to done_ Done http://gerrit.cloudera.org:8080/#/c/5494/1/be/src/exec/kudu-scan-node.h File be/src/exec/kudu-scan-node.h: PS1, Line 96: For performance reasons, > remove this, it makes it sound like the performance reason _is what makes i Done Line 99: /// contention. > Does it make sense to add small comments at the particular places, explaini Yes, I've added it now in the place where it may seem confusing otherwise. -- To view, visit http://gerrit.cloudera.org:8080/5494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72c5f1fecf4bcf737d71a1fa13e59361604485f0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
