Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode ......................................................................
IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode This patch adds a comment to clarify that it's safe to optimistically read 'done_' in some places in KuduScanNode. This is to avoid some confusion as the code synchronizes access to the variable in certain places but not in others. Also, did some miscellaneous cleanup in a couple of places. Change-Id: I72c5f1fecf4bcf737d71a1fa13e59361604485f0 Reviewed-on: http://gerrit.cloudera.org:8080/5494 Reviewed-by: Matthew Jacobs <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/exec/kudu-scan-node.cc M be/src/exec/kudu-scan-node.h 2 files changed, 13 insertions(+), 14 deletions(-) Approvals: Impala Public Jenkins: Verified Matthew Jacobs: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72c5f1fecf4bcf737d71a1fa13e59361604485f0 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]>
