Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Make it easy to work with big numbers ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5902/2/be/src/util/decimal-util.h File be/src/util/decimal-util.h: Line 44: template<typename T> > If this is only supposed to be called at compile-time, all the parameters c Didn't think of that. Line 45: static constexpr T LargeNum(int digit, int precision, int base = 10) { > This is the kind of API that I would foul up by swapping the params. Is the digit < base would be a good check - can be a static assertion -- To view, visit http://gerrit.cloudera.org:8080/5902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5095a366d914cebb0b64bd434a08dbb55c90ed30 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: Yes
