Jim Apple has posted comments on this change. Change subject: IMPALA-2020: Make it easy to work with big numbers ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5902/4/be/src/util/decimal-util.cc File be/src/util/decimal-util.cc: Line 25: static constexpr T AllNines(unsigned precision) { If it's going to be this specific, why not const int128_t DecimalUtil::MAX_UNSCALED_DECIMAL16 = 99 + 100 * (MAX_UNSCALED_DECIMAL8 + (1 + MAX_UNSCALED_DECIMAL8) * static_cast<int128_t>(MAX_UNSCALED_DECIMAL8)); -- To view, visit http://gerrit.cloudera.org:8080/5902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5095a366d914cebb0b64bd434a08dbb55c90ed30 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
