Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu ......................................................................
Patch Set 1: (1 comment) Nice! I think it looks good, just a comment about some additional test cases as we discussed. Maybe Alex/Marcel can think of other corner cases we need to consider but seems straightforward to me. http://gerrit.cloudera.org:8080/#/c/5958/1/testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test File testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test: would be good to add some negative test cases demonstrating why it doesn't make sense when there are casts: [localhost:21000] > select cast(10000000000000000000 as tinyint); Query: select cast(10000000000000000000 as tinyint) Query submitted at: 2017-02-09 14:23:55 (Coordinator: http://mj-desktop.ca.cloudera.com:25000) Query progress can be monitored at: http://mj-desktop.ca.cloudera.com:25000/query_plan?query_id=ed4cdbe536ffdca4:ad65d6a000000000 +---------------------------------------+ | cast(10000000000000000000 as tinyint) | +---------------------------------------+ | 0 | +---------------------------------------+ Fetched 1 row(s) in 0.06s [localhost:21000] > select cast("10000000000000000000" as tinyint); Query: select cast("10000000000000000000" as tinyint) Query submitted at: 2017-02-09 14:24:09 (Coordinator: http://mj-desktop.ca.cloudera.com:25000) Query progress can be monitored at: http://mj-desktop.ca.cloudera.com:25000/query_plan?query_id=6146365d55608409:d09dc18200000000 +-----------------------------------------+ | cast('10000000000000000000' as tinyint) | +-----------------------------------------+ | NULL | +-----------------------------------------+ Fetched 1 row(s) in 0.01s -- To view, visit http://gerrit.cloudera.org:8080/5958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c96fec8d41f77222879c0ffdd6940b168e47e65 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
