Alex Behm has posted comments on this change. Change subject: IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu ......................................................................
Patch Set 2: (1 comment) I think we should also add an end-to-end. In particular, I'm curious what Kudu will do when we pass it an IS NOT NULL predicate on a primary-key column or another non-nullable column. http://gerrit.cloudera.org:8080/#/c/5958/2/testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test File testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test: Line 152: predicates: CAST(date_string_col AS TINYINT) IS NULL can move this into the query above, so we have one query with all the cases? -- To view, visit http://gerrit.cloudera.org:8080/5958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c96fec8d41f77222879c0ffdd6940b168e47e65 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
