Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough ......................................................................
Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/5816/4/be/src/exec/union-node.cc File be/src/exec/union-node.cc: Line 133: DCHECK(!IsInSubplan()); > Do we have coverage of that kind of plan shape though? If someone else come Done. Added a Union + subplan test to Planner tests and end to end tests. http://gerrit.cloudera.org:8080/#/c/5816/6/be/src/exec/union-node.cc File be/src/exec/union-node.cc: Line 103: if (!children_.empty()) RETURN_IF_ERROR(child(0)->Open(state)); > I think we need to reset 'child_batch_' here so that it has the correct 'ro I don't think we need to reset here. It already gets reset on line 179 in this file. Line 114: if (UNLIKELY(child_idx_ >= children_.size() && > My preference is to remove this code if it's not needed for correctness and Done Line 153: // Even though the child is at eos, it's not OK to Close() it here, like we do in > I think this comment over-explains some resource management things that are Done http://gerrit.cloudera.org:8080/#/c/5816/4/fe/src/main/java/org/apache/impala/planner/UnionNode.java File fe/src/main/java/org/apache/impala/planner/UnionNode.java: Line 266: Preconditions.checkState(exprList.size() == slots.size()); > nullableTupleIds_ in child PlanNode is essentially part of the row layout a Done http://gerrit.cloudera.org:8080/#/c/5816/4/testdata/workloads/functional-planner/queries/PlannerTest/union.test File testdata/workloads/functional-planner/queries/PlannerTest/union.test: Line 3103: ==== > Was this addressed? Yes, added a union + join test with several joins in Planner and end to end tests. See PlannerTest/union.test and QueryTest/union.test -- To view, visit http://gerrit.cloudera.org:8080/5816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
