Alex Behm has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough ......................................................................
Patch Set 7: (7 comments) I'm pretty happy with this change http://gerrit.cloudera.org:8080/#/c/5816/8/be/src/exec/union-node.h File be/src/exec/union-node.h: Line 67: // Which children can be passed through, without being materialized. duplicate 'without' http://gerrit.cloudera.org:8080/#/c/5816/8/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: Line 225: // Indicates whether passthrough should be disabled in union nodes. enabled http://gerrit.cloudera.org:8080/#/c/5816/8/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: PS8, Line 255: d enabled http://gerrit.cloudera.org:8080/#/c/5816/8/fe/src/main/java/org/apache/impala/planner/UnionNode.java File fe/src/main/java/org/apache/impala/planner/UnionNode.java: Line 267: // nullability can be considered to be part of the physical row layout. remove (this was moved inside computePassThrough http://gerrit.cloudera.org:8080/#/c/5816/8/testdata/workloads/functional-query/queries/QueryTest/union.test File testdata/workloads/functional-query/queries/QueryTest/union.test: Line 1059: select bigint_col from functional.alltypestiny where bigint_col > 0 use unqualified table names everywhere (and fix the one above while you are here), so we get coverage over all file formats Line 1124: ---- QUERY Move this test into nested-types-subplan.test, otherwise this test will fail on the legacy joins/agg build since nested types are not supported there (nested-types-subplan.test will be skipped) Line 1126: select COUNT(c.c_custkey), COUNT(v.tot_price) lowercase count -- To view, visit http://gerrit.cloudera.org:8080/5816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
