Michael Ho has posted comments on this change. Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2 ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/5952/6/fe/src/main/java/org/apache/impala/catalog/ScalarType.java File fe/src/main/java/org/apache/impala/catalog/ScalarType.java: PS6, Line 115: precision Can precision be > MAX_PRECISION in this case ? PS6, Line 138: ClipPrecScale May help to clarify that how this function and the *AdjustPrecScale() are related to decimal_v1 vs decimal_v2. Otherwise, it may be hard to tell which one to use. Line 148: * preserve at least MIN_ADJUSTED_SCALE (unless the desired scale was less). MIN_ADJUSTED_SCALE for scale (unless ...) http://gerrit.cloudera.org:8080/#/c/5952/6/fe/src/main/java/org/apache/impala/catalog/Type.java File fe/src/main/java/org/apache/impala/catalog/Type.java: PS6, Line 65: nit: blank space -- To view, visit http://gerrit.cloudera.org:8080/5952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83e7f7787edfa4b4bddc25945090542a0e90881b Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
