Dan Hecht has uploaded a new patch set (#7). Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2 ......................................................................
IMPALA-4370: Divide and modulo result types for DECIMAL version V2 Implement the new DECIMAL return type rules for divide and modulo expressions, active when query option DECIMAL_V2=1. See the comment in the code for more details. A couple of examples that show why new return type rules for divide are desirable. For modulo, the return types are actually equivalent, though the rules are expressed differently to have consistency with how precision fixups are handled for each version. DECIMAL Version 1: +-------------------------------------------------------+ | cast(1 as decimal(20,0)) / cast(3 as decimal(20,0)) | +-----------------------------------------------------+ | 0 | +-------------------------------------------------------+ DECIMAL Version 2: +-------------------------------------------------------+ | cast(1 as decimal(20,0)) / cast(3 as decimal(20,0)) | +-----------------------------------------------------+ | 0.333333333333333333 | +-------------------------------------------------------+ DECIMAL Version 1: +-------------------------------------------------------+ | cast(1 as decimal(6,0)) / cast(0.1 as decimal(38,38)) | +-------------------------------------------------------+ | NULL | +-------------------------------------------------------+ WARNINGS: UDF WARNING: Expression overflowed, returning NULL DECIMAL Version 2: +-------------------------------------------------------+ | cast(1 as decimal(6,0)) / cast(0.1 as decimal(38,38)) | +-------------------------------------------------------+ | 10.000000 | +-------------------------------------------------------+ Change-Id: I83e7f7787edfa4b4bddc25945090542a0e90881b --- M be/src/exprs/expr-test.cc M be/src/runtime/decimal-value.inline.h M be/src/testutil/impalad-query-executor.h M fe/src/main/java/org/apache/impala/analysis/ArithmeticExpr.java M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M fe/src/main/java/org/apache/impala/analysis/TypesUtil.java M fe/src/main/java/org/apache/impala/catalog/ScalarType.java M fe/src/main/java/org/apache/impala/catalog/Type.java A testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test M tests/query_test/test_decimal_queries.py 10 files changed, 325 insertions(+), 75 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/5952/7 -- To view, visit http://gerrit.cloudera.org:8080/5952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I83e7f7787edfa4b4bddc25945090542a0e90881b Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com>
