David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md File nikola_site_generator/posts/where-did-i-leave-my-keys.md: PS1, Line 43: SetsContainTheirElements Minor stylistic point. Let's follow strict PEP-8 for blog posts. PEP-8 calls for 4 space indents, stipulates that only classes are capitalized, and also advises against camel case for function names. PS1, Line 50: s.add(set()) This will throw an exception. You can't add a set to a set. Members of sets, like keys in dictionaries, need to be hashable, and so can't be mutable types. >>> s = set() >>> s.add(set()) Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: unhashable type: 'set' -- To view, visit http://gerrit.cloudera.org:8080/5995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
