David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md File nikola_site_generator/posts/where-did-i-leave-my-keys.md: PS1, Line 43: SetsContainTheirElements > I'v changed it to more closely match to code in tests/. To encourage develo I think cut-and-paste code from Impala could be a special case. FWIW, if I scan a blog post involving python code, and I see that the author hasn't followed commonly recognized PEP-8 conventions, it immediately colors how I read piece. Like, I immediately become a little skeptical. I'd at least change the function names to sets_contain_their_elements and change_keys, respectively. -- To view, visit http://gerrit.cloudera.org:8080/5995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-HasComments: Yes
