Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5840/2/be/src/exec/kudu-scanner.cc File be/src/exec/kudu-scanner.cc: Line 149: > I think Thomas is right and the query may crash if there is a difference in I couldn't reproduce any failures, but looking at TupleDescriptor I agree it seems like it could be possible to crash. Good call Thomas & Alex. I'll check that here too. Will the Kudu-side validation check that the projection is 100% identical to what the scan token expects? Nullability etc. included? In theory it should, thought it looks like it's missing on the Kudu side as well, so I filed a JIRA on them https://issues.apache.org/jira/browse/KUDU-1881 . Thanks for pointing this out. http://gerrit.cloudera.org:8080/#/c/5840/6/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java: Line 161: if (!colType.matchesType(kuduColType)) { > Shouldn't this use equals() instead of matchesType()? Done -- To view, visit http://gerrit.cloudera.org:8080/5840 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d43f5bb9811e728ad592933066d006c8fb4553a Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
