Alex Behm has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5840/7/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: Line 101: def test_kudu_col_changed(self, cursor, kudu_client, unique_database): Tests lgtm, but there seems to be a lot of repeated boilerplate stuff. Maybe you can take another pass and see if it makes sense to factor out some parts to condense the code? Line 106: kudu_tbl_name = "impala::%s.foo" % unique_database seems worth factoring out this function and adding a comment that it must be kept in sync with the FE table-name-generation behavior -- To view, visit http://gerrit.cloudera.org:8080/5840 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d43f5bb9811e728ad592933066d006c8fb4553a Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
