Alex Behm has posted comments on this change. Change subject: IMPALA-4282: Remove max length check for type strings. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6034/2//COMMIT_MSG Commit Message: Line 12: message, but has the severe drawback of not having > what happens now when the type string is too long? do we still get an erro Yes. The Metastore backend DB will reject the INSERT due to a constraint violation, and that gets bubbled up through the ORM layer and finally makes it to Impala in a very cryptic form. You can see a flavor of the error in the JIRA. -- To view, visit http://gerrit.cloudera.org:8080/6034 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01f5e503e14feee857bbdf80b3ef4f5a8b57fb2d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
