Dan Hecht has posted comments on this change. Change subject: IMPALA-4282: Remove max length check for type strings. ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/6034/2/fe/src/main/java/org/apache/impala/analysis/ColumnDef.java File fe/src/main/java/org/apache/impala/analysis/ColumnDef.java: Line 185: comment_.length() > MetaStoreUtil.CREATE_MAX_COMMENT_LENGTH) { why still do this, rather than rely on the lower layer to error like the type field? especially given the comment above CREATE_MAX_COMMENT_LENGTH that this is conservative. -- To view, visit http://gerrit.cloudera.org:8080/6034 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01f5e503e14feee857bbdf80b3ef4f5a8b57fb2d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
