John Russell has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. Hid instances of CM and rewrote for upstream docs when necessary. This still leaves occurences of CM in the XML, but not in the rendered documentation. A later project will remove ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6067/1/docs/topics/impala_impala_shell.xml File docs/topics/impala_impala_shell.xml: PS1, Line 96: Watch out for trailing spaces and/or tabs left behind in new blank lines or newly split lines. In vi, you can find such things by doing /[ \t][ \t]*$ which will leave the cursor at the start of whichever sequence of spaces and tabs comes at the end of a line. At that point, you can press D to remove from the cursor position to the end of the line -- i.e. all trailing spaces and tabs. http://gerrit.cloudera.org:8080/#/c/6067/1/docs/topics/impala_proxy.xml File docs/topics/impala_proxy.xml: PS1, Line 336: <li audience="hidden"> Isn't this too blunt an instrument to hide the whole <li>? Everything under here (except little things like the CM-related <note>) is appropriate for generic Apache Impala usage. The <ol>, <codeblock>, etc. are all inside this <li> and will be hidden too. http://gerrit.cloudera.org:8080/#/c/6067/1/docs/topics/impala_timeouts.xml File docs/topics/impala_timeouts.xml: PS1, Line 188: Various client applications We may as well preserve part of this sentence, at least the example of: pressing <codeph>^C</codeph> in <cmdname>impala-shell</cmdname> since that's applicable to generic Apache Impala. -- To view, visit http://gerrit.cloudera.org:8080/6067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale <[email protected]> Gerrit-Reviewer: Ambreen Kazi <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-HasComments: Yes
