Lars Volker has posted comments on this change. Change subject: IMPALA-2328: Address additional comments ......................................................................
Patch Set 2: (10 comments) Thanks for the review. Please see PS3. http://gerrit.cloudera.org:8080/#/c/6147/1/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 487: DCHECK_EQ(min_max_tuple_desc->slots().size(), min_max_conjuncts_ctxs_.size()); > DCHECK_EQ Done Line 494: SchemaNode* node = nullptr; > nullptr Done Line 501: // We are selecting a column that is not in the file. We would set its slot to NULL > Remove "In this case", that's clear. Done Line 502: // during the scan, so any predicate would evaluate to false. Return early. > Suggest minor rewording for clarity: Done Line 507: if (pos_field) { > Does the FE guarantee that such predicates are not sent to the BE for min/m I changed the code in HdfsScanNode.java to handle this correctly. I also added a test with that query. http://gerrit.cloudera.org:8080/#/c/6147/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: Line 342: if (slot == null) continue; > You can check slot.getDesc().getColumn() to see if the slot corresponds to Done http://gerrit.cloudera.org:8080/#/c/6147/1/testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test File testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test: Line 234: create table name_resolve stored as parquet as select * from functional_parquet.alltypessmall; > no need for this if we are using unique_database Done Line 256: # Predicates with explicit casts are not supported when evaluating parquet::Statistics. > The above test seems sufficient. Done Line 264: ---- QUERY > Might be good to have an example here that demonstrates why it's not easy t Done http://gerrit.cloudera.org:8080/#/c/6147/1/tests/query_test/test_parquet_stats.py File tests/query_test/test_parquet_stats.py: Line 24: This suite tests runtime optimizations based on Parquet statistics. > Tests runtime optimizations based on Parquet statistics? Done -- To view, visit http://gerrit.cloudera.org:8080/6147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54c205fad7afc4a0b0a7d0f654859de76db29a02 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
