Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2328: Address additional comments ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6147/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 494: SchemaNode* node = nullptr; prefix with comment that explains what you're doing. Line 509: err << "Statistics not supported for pos fields: " << slot_desc->DebugString(); 'pos fields' may not be very useful/comprehensible in the logging output. -- To view, visit http://gerrit.cloudera.org:8080/6147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54c205fad7afc4a0b0a7d0f654859de76db29a02 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
