Dan Hecht has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 ......................................................................
Patch Set 6: Code-Review+2 (1 comment) This is okay with me, though I still think it would be nice to group the code that does ambiguity checking close together (or even factor into a separate subroutine). If you do that, I can take another look. Otherwise, okay to go with this change, but please fix the nit with DCHECK_LT. http://gerrit.cloudera.org:8080/#/c/5969/6/be/src/exprs/timestamp-functions.cc File be/src/exprs/timestamp-functions.cc: Line 133: // NULL". > For some context, you can take a look at this discussion: https://gerrit.cl Sure, returning null seems reasonable in these cases. It would just be nice to factor the code in a way such that all the code that determines these ambiguous cases is factored into a single location. Is it the local_date_time constructor that does the validation in other cases? -- To view, visit http://gerrit.cloudera.org:8080/5969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e3f2c9f6ba29749a26bc1087e664637bc02528 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
