Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5969/6/be/src/exprs/timestamp-functions.cc File be/src/exprs/timestamp-functions.cc: Line 133: // NULL". > Sure, returning null seems reasonable in these cases. It would just be nice Yes, I checked, the ambiguity is checked in the constructor of local_date_time. An exception is not thrown because we set local_date_time::NOT_DATE_TIME_ON_ERROR. There is only 1 ambiguous case that we have to treat specially. I don't think it's a good idea to create a function IsAmbiguous(ts_value, timezone) to handle this one case. The rest of the cases would still be handled in the constructor, so it wouldn't be in 1 place. In any case, the ambiguity is handled 1 location today: the ToUtc() function. What do you think? PS6, Line 134: DCHECK > DCHECK_LT Done -- To view, visit http://gerrit.cloudera.org:8080/5969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6e3f2c9f6ba29749a26bc1087e664637bc02528 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
