Bharath Vissapragada has posted comments on this change. Change subject: Remove deadcode from frontend - Part 1 ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6172/1/fe/src/main/java/org/apache/impala/analysis/AnalyticInfo.java File fe/src/main/java/org/apache/impala/analysis/AnalyticInfo.java: Line 162 > Yikes! We don't call this anywhere? Seems like we should. Yes. Should I not remove it in this clean up so that we can fix and add callers in subsequent CRS? http://gerrit.cloudera.org:8080/#/c/6172/1/fe/src/main/java/org/apache/impala/analysis/PartitionListItem.java File fe/src/main/java/org/apache/impala/analysis/PartitionListItem.java: Line 23 > Nice Yes, been lying around for a while. -- To view, visit http://gerrit.cloudera.org:8080/6172 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fa810cf4eaf9f9ff545fe80a11bc62619039224 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-HasComments: Yes
