Bharath Vissapragada has posted comments on this change. Change subject: Remove deadcode from frontend - Part 1 ......................................................................
Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/6172/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java: PS2, Line 80: > This function is used externally. Done PS2, Line 81: > This function is used externally. Done http://gerrit.cloudera.org:8080/#/c/6172/2/fe/src/main/java/org/apache/impala/analysis/DescribeDbStmt.java File fe/src/main/java/org/apache/impala/analysis/DescribeDbStmt.java: PS2, Line 57: > This function is called externally. Done http://gerrit.cloudera.org:8080/#/c/6172/2/fe/src/main/java/org/apache/impala/analysis/LikePredicate.java File fe/src/main/java/org/apache/impala/analysis/LikePredicate.java: PS2, Line 167: > This function is called externally. Done http://gerrit.cloudera.org:8080/#/c/6172/2/fe/src/main/java/org/apache/impala/analysis/PartitionDef.java File fe/src/main/java/org/apache/impala/analysis/PartitionDef.java: PS2, Line 55: > This function is used externally. Done http://gerrit.cloudera.org:8080/#/c/6172/2/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java File fe/src/main/java/org/apache/impala/analysis/QueryStmt.java: PS2, Line 350: > This function is used externally. Done http://gerrit.cloudera.org:8080/#/c/6172/2/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java File fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java: PS2, Line 52: > This function is used externally. Done http://gerrit.cloudera.org:8080/#/c/6172/2/fe/src/main/java/org/apache/impala/analysis/SelectListItem.java File fe/src/main/java/org/apache/impala/analysis/SelectListItem.java: Line 57 > This function is used externally Done http://gerrit.cloudera.org:8080/#/c/6172/2/fe/src/main/java/org/apache/impala/analysis/WithClause.java File fe/src/main/java/org/apache/impala/analysis/WithClause.java: PS2, Line 139: > This function is used externally. Done -- To view, visit http://gerrit.cloudera.org:8080/6172 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fa810cf4eaf9f9ff545fe80a11bc62619039224 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Ravi Shetye <[email protected]> Gerrit-HasComments: Yes
